Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clearly state the operating system and architecture in the search result #716

Merged
merged 2 commits into from
Sep 14, 2021
Merged

Clearly state the operating system and architecture in the search result #716

merged 2 commits into from
Sep 14, 2021

Conversation

fleeto
Copy link
Contributor

@fleeto fleeto commented Sep 11, 2021

Searching images with krew on linux/arm64:

$ kubectl krew search images
NAME    DESCRIPTION                                 INSTALLED
images  Show container images used in the cluster.  unavailable on Linux

In fact, it just lacks support for linux/arm64.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 11, 2021
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 11, 2021
@fleeto
Copy link
Contributor Author

fleeto commented Sep 13, 2021

/assign @soltysh

@ahmetb
Copy link
Member

ahmetb commented Sep 13, 2021

/lgtm
/approve
Thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, fleeto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 13, 2021
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 14, 2021
@corneliusweig
Copy link
Contributor

/lgtm
Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 14, 2021
@k8s-ci-robot k8s-ci-robot merged commit b750994 into kubernetes-sigs:master Sep 14, 2021
@fleeto fleeto deleted the fix-err-msg branch September 15, 2021 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriskim06 chriskim06 Awaiting requested review from chriskim06

@corneliusweig corneliusweig Awaiting requested review from corneliusweig

Assignees

@ahmetb ahmetb

@soltysh soltysh

@corneliusweig corneliusweig

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fleeto @ahmetb @k8s-ci-robot @corneliusweig @soltysh