Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support LICENSES filename in manifest validation #692

Merged
merged 1 commit into from
Feb 16, 2021
Merged

Support LICENSES filename in manifest validation #692

merged 1 commit into from
Feb 16, 2021

Conversation

bashofmann
Copy link
Contributor

Some plugins like https://github.com/jetstack/cert-manager store the license information in a file called LICENSES. This adds support for this filename to the manifest validation.

Fixes #691

@bashofmann
Support LICENSES filename in manifest validation
a42699a 
Some plugins like https://github.com/jetstack/cert-manager store the license information in a file called LICENSES. This adds support for this filename to the manifest validation.

Fixes kubernetes-sigs#691

Signed-off-by: Bastian Hofmann <bashofmann@gmail.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 16, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @bashofmann!

It looks like this is your first PR to kubernetes-sigs/krew 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/krew has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 16, 2021
@bashofmann bashofmann mentioned this pull request Feb 16, 2021
Merged
@corneliusweig
Copy link
Contributor

Makes sense. Thank you!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 16, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bashofmann, corneliusweig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 16, 2021
@k8s-ci-robot k8s-ci-robot merged commit 60ca400 into kubernetes-sigs:master Feb 16, 2021
@ahmetb
Copy link
Member

ahmetb commented Feb 16, 2021

do we need a new release ASAP or not?

@bashofmann bashofmann deleted the validate-support-licenses-file branch February 16, 2021 19:59
@bashofmann
Copy link
Contributor Author

The CI pipeline in krew-index currently uses the validate check from a specific commit hash (https://github.com/kubernetes-sigs/krew-index/blob/master/.github/workflows/ci.yml#L49), which points to this commit 9fc1c54.
I guess we could just change it there to the new commit without having to da a krew release. What do you think?

@ahmetb
Copy link
Member

ahmetb commented Feb 16, 2021

Yeah I guess only the validation is broken, there's no user impact. That would work.

bashofmann added a commit to bashofmann/krew-index that referenced this pull request Feb 17, 2021
@bashofmann
Update validate-krew-manifest
0acc168 
New functionality:

* Add support for LICENSES file in license check, which is uses by cert-manager (kubernetes-sigs/krew#692)

Signed-off-by: Bastian Hofmann <bashofmann@gmail.com>
@bashofmann bashofmann mentioned this pull request Feb 17, 2021
Merged
k8s-ci-robot pushed a commit to kubernetes-sigs/krew-index that referenced this pull request Feb 17, 2021
@bashofmann
Update validate-krew-manifest (#1041)
616e960 
New functionality:

* Add support for LICENSES file in license check, which is uses by cert-manager (kubernetes-sigs/krew#692)

Signed-off-by: Bastian Hofmann <bashofmann@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriskim06 chriskim06 Awaiting requested review from chriskim06

@corneliusweig corneliusweig Awaiting requested review from corneliusweig

Assignees

@corneliusweig corneliusweig

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validation for cert-manager plugin fails because of license check
4 participants
@bashofmann @k8s-ci-robot @corneliusweig @ahmetb