site: make footer show last updated #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
needs-rebase
Little JS snippet to actually show something like:
· Page last updated [3 days ago](link to commit).
Instead of:
· Build from commit [abcdef](link to commit).
Written in ES6 syntax (https://caniuse.com/#search=es6).
Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
ahmetb
force-pushed
the
footer-last-updated
branch
from
6b6a285 to
cca0e5f
Compare
k8s-ci-robot
removed
the
needs-rebase
site/layouts/partials/footer.html
Outdated
| `href="https://github.com/kubernetes-sigs/krew/commit/${commitHash}">` + | ||
| `${text}</a>.`; | ||
| }; | ||
| writeLastMod({{- .Lastmod.Unix -}}, '{{- .GitInfo.Hash -}}'); |
There was a problem hiding this comment.
Shouldn't this be indented one more level?
|
Works like a charm! |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
k8s-ci-robot
removed
the
lgtm
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmetb, corneliusweig The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Little JS snippet to actually show something like:
Instead of:
Written in ES6 syntax (https://caniuse.com/#search=es6).