-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use static URL to download assets from latest release #513
Use static URL to download assets from latest release #513
Conversation
This also simplifies the release process for krew, because the version number does not need to be updated when releasing a new version.
@ahmetb was there a particular reason why the version should be hardcoded and thus visible that I'm not aware of? |
Codecov Report
@@ Coverage Diff @@
## master #513 +/- ##
=======================================
Coverage 59.12% 59.12%
=======================================
Files 23 23
Lines 1003 1003
=======================================
Hits 593 593
Misses 350 350
Partials 60 60 Continue to review full report at Codecov.
|
I think we didn’t know “latest” worked? |
Oh it's because for a release we needed to adjust the hardcoded version number in |
Hmm but we still need this:
This ensures we have a clean commit that tags the release (we can add I frequently follow this pattern in my repos, it helps a lot in the GitHub web UI, as users go to a "commit" that explains the tag; not some irrelevant patch. |
03674e5
to
30e0bb3
Compare
Ok, that makes sense. Added back the instructions for creating a release commit. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmetb, corneliusweig The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This also simplifies the release process for krew, because the version
number does not need to be updated when releasing a new version.
Fixes #...
Related issue: #...