Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve github action #493

Merged
merged 2 commits into from
Feb 6, 2020
Merged

Improve github action #493

merged 2 commits into from
Feb 6, 2020

Conversation

ferhatelmas
Copy link
Contributor

  • whitespace (trim and indentation)
  • step naming
  • drop id from setup

Related to the comment: #491 (comment)

Own initiative, feel free to close abruptly.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 4, 2020
@ferhatelmas ferhatelmas mentioned this pull request Feb 4, 2020
Merged
@ahmetb
Copy link
Member

ahmetb commented Feb 4, 2020

Can we not do the indentation? I find unnecessary yaml indents superfluous. :)

@codecov-io
Copy link

codecov-io commented Feb 4, 2020 •
edited
Loading

Codecov Report

Merging #493 into master will increase coverage by 0.52%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #493      +/-   ##
========================================
+ Coverage   56.47%    57%   +0.52%     
========================================
  Files          19     21       +2     
  Lines         926    956      +30     
========================================
+ Hits          523    545      +22     
- Misses        350    357       +7     
- Partials       53     54       +1
Impacted Files Coverage Δ
cmd/krew/cmd/internal/setup_check.go 91.66% <0%> (ø)
cmd/krew/cmd/internal/security_notice.go 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4303b6a...c04ddb8. Read the comment docs.

@ferhatelmas
Copy link
Contributor Author

Can we not do the indentation? I find unnecessary yaml indents superfluous. :)

As you wish.

In general, I setup lint in my environment.

@ahmetb
Copy link
Member

ahmetb commented Feb 4, 2020

YAML indentation is not done in Kubernetes ecosystem, in general so avoiding would be the best.

@ferhatelmas
Improve github action
a9c5c56 
* whitespace (trim)
* better step naming
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 5, 2020
@ferhatelmas
Copy link
Contributor Author

YAML indentation is not done in Kubernetes ecosystem, in general so avoiding would be the best.

Better to be consistent. Reverted indentation but kept the trimming.

corneliusweig
corneliusweig reviewed Feb 5, 2020
View reviewed changes
Copy link
Contributor

@corneliusweig corneliusweig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me.

.github/workflows/ci.yml Outdated
- name: Verify code quality

- name: Ensure go modul is tidy
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a typo here.

ahmetb
ahmetb reviewed Feb 5, 2020
View reviewed changes
.github/workflows/ci.yml Outdated
- name: Verify code quality

- name: Ensure go modul is tidy
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure go.mod is already tidied

@ahmetb
Copy link
Member

ahmetb commented Feb 5, 2020

nits but /lgtm

@ahmetb
Copy link
Member

ahmetb commented Feb 6, 2020

/lgtm
/approve
Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 6, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, ferhatelmas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2020
@k8s-ci-robot k8s-ci-robot merged commit 867ad1e into kubernetes-sigs:master Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmetb ahmetb ahmetb left review comments

@corneliusweig corneliusweig corneliusweig left review comments

@soltysh soltysh Awaiting requested review from soltysh

Assignees

@ahmetb ahmetb

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ferhatelmas @ahmetb @codecov-io @k8s-ci-robot @corneliusweig