-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move implementation details to internal #422
Move implementation details to internal #422
Conversation
HUGE if we can get it in ASAP before it starts introducing merge conflicts everywhere :) |
Codecov Report
@@ Coverage Diff @@
## master #422 +/- ##
=======================================
Coverage 56.41% 56.41%
=======================================
Files 19 19
Lines 927 927
=======================================
Hits 523 523
Misses 349 349
Partials 55 55
Continue to review full report at Codecov.
|
I'll go ahead with this, seeing no issues locally. I'll send a PR to move cmd/* commands to v0.3.3 later. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmetb, ferhatelmas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
move all packages into
internal
exceptpkg/index
andpkg/constants
.fixes #291