-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add integration tests for krew install
with --archive and --manifest options
#245
Merged
k8s-ci-robot
merged 6 commits into
kubernetes-sigs:master
from
corneliusweig:w/install-manifest-archive
Jul 9, 2019
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
828074f
Add test cases for `krew install` with --archive and --manifest options
corneliusweig c5e10ff
Improve formatting
corneliusweig 830cf26
ReplaceAll was added in go 1.12, but krew uses 1.11
corneliusweig 64a2eef
Rename test plugin from `test-foo` to `foo`
corneliusweig 72e1598
Use wildcard platform selector in test data
corneliusweig d757c9c
Add windows version of the test plugin for testing on windows
corneliusweig File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
apiVersion: krew.googlecontainertools.github.com/v1alpha2 | ||
kind: Plugin | ||
metadata: | ||
name: foo | ||
spec: | ||
version: "v0.1.0" | ||
shortDescription: A valid plugin for integration tests | ||
platforms: | ||
- uri: https://foo.bar/foo.tar.gz | ||
sha256: 354bad230cdd0966fc8c919476c4e6c7f2078b04a6ff7dead6a811cdc101d31e | ||
bin: foo.sh | ||
files: | ||
- from: ./foo.sh | ||
to: "." | ||
selector: | ||
matchExpressions: | ||
- key: os | ||
operator: In | ||
values: ["darwin", "linux"] | ||
- uri: https://foo.bar/foo.tar.gz | ||
ahmetb marked this conversation as resolved.
Show resolved
Hide resolved
|
||
sha256: 354bad230cdd0966fc8c919476c4e6c7f2078b04a6ff7dead6a811cdc101d31e | ||
bin: foo.bat | ||
files: | ||
- from: ./foo.bat | ||
to: "." | ||
selector: | ||
matchLabels: | ||
os: windows |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
apiVersion: krew.googlecontainertools.github.com/v1alpha2 | ||
kind: Plugin | ||
ahmetb marked this conversation as resolved.
Show resolved
Hide resolved
|
||
metadata: | ||
name: konfig | ||
spec: | ||
version: "v0.2.0" | ||
shortDescription: a plugin in central index with small size | ||
platforms: | ||
- uri: https://github.com/corneliusweig/konfig/releases/download/v0.2.0/bundle.tar.gz | ||
sha256: 7dc7b884ca92e3c9b39f905cc11bcf31e79b9c929741a4383d9ff61414101962 | ||
bin: konfig-krew | ||
files: | ||
- from: ./konfig-krew | ||
to: "." | ||
selector: | ||
matchExpressions: | ||
- key: os | ||
operator: In | ||
values: ["darwin", "linux"] | ||
- uri: https://github.com/corneliusweig/konfig/releases/download/v0.2.0/bundle.tar.gz | ||
sha256: 7dc7b884ca92e3c9b39f905cc11bcf31e79b9c929741a4383d9ff61414101962 | ||
bin: konfig-krew.exe | ||
files: | ||
- from: ./konfig-krew | ||
to: konfig-krew.exe | ||
selector: | ||
matchLabels: | ||
os: windows |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need to address this but: I feel like these small constants are hurting the readability quite a bit, unless needed, we can probably avoid in the future.