Rename /test --> /integration_test #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- move directory - remove 'krew' subpackage (merge with main package) - make the package _test.go-only, by merging /test/krew package - fix a bug with run-integration-tests.sh where it silently failed when the binary file didn't exist (due to readlink failing inside the subshell). - use testutil.TempDir() in the integration tests (per validate-code-patterns) Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
k8s-ci-robot
added
the
cncf-cla: yes
This comment has been minimized.
This comment has been minimized.
k8s-ci-robot
added
approved
This comment has been minimized.
This comment has been minimized.
corneliusweig
approved these changes
Jul 2, 2019
There was a problem hiding this comment.
Looks good. You found a way to keep the test code out of the business code :).
Have you also thought about splitting the test file into smaller units for each subcommand, as #229 suggests?
|
I was gonna do that in another PR. |
|
Sure |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
binary file didn't exist (due to readlink failing inside the subshell).
Fixes #229.
/assign @corneliusweig