-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Put local imports in a separate import group #222
Put local imports in a separate import group #222
Conversation
Codecov Report
@@ Coverage Diff @@
## master #222 +/- ##
=======================================
Coverage 54.35% 54.35%
=======================================
Files 13 13
Lines 701 701
=======================================
Hits 381 381
Misses 269 269
Partials 51 51
Continue to review full report at Codecov.
|
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmetb, corneliusweig The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
As pointed out by @ahmetb here #195 (comment), imports are not sorted correctly. This PR applies standard sort order so that local imports are separated in their own import group. In addition, it also configures the linters to fail if imports are not sorted as expected.