-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix readme for wrong use of fish subshell in string #215
Conversation
Welcome @kirrmann! |
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Codecov Report
@@ Coverage Diff @@
## master #215 +/- ##
=======================================
Coverage 54.35% 54.35%
=======================================
Files 13 13
Lines 701 701
=======================================
Hits 381 381
Misses 269 269
Partials 51 51 Continue to review full report at Codecov.
|
registered to CLA |
recheck CLA |
/check-cla |
recheck CLA |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmetb, kirrmann The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The scripts fails and outputs an error
cd: The directory '(mktemp -d)' does not exist
. This error appears because()
in strings aren't generally recognized as subshells in fish. To fix this I set a variable which we use tocd
to. There seems to be no way to quote subshell commands in fish correctly.