test for 'kubectl' prefix in help strings (#551)

Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
kubernetes-sigs · Mar 13, 2020 · 927e4d7 · 927e4d7
1 parent f7fed5b
commit 927e4d7
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 36 deletions.
diff --git a/cmd/krew/cmd/root_test.go b/cmd/krew/cmd/root_test.go
diff --git a/integration_test/help_test.go b/integration_test/help_test.go
@@ -14,7 +14,10 @@
 
 package integrationtest
 
-import "testing"
+import (
+	"regexp"
+	"testing"
+)
 
 func TestKrewHelp(t *testing.T) {
 	skipShort(t)
@@ -27,3 +30,22 @@ func TestKrewHelp(t *testing.T) {
 	test.Krew("-h").RunOrFail()
 	test.Krew("--help").RunOrFail()
 }
+
+func TestRootHelpShowsKubectlPrefix(t *testing.T) {
+	skipShort(t)
+	test, cleanup := NewTest(t)
+	defer cleanup()
+
+	out := string(test.Krew("help").RunOrFailOutput())
+
+	expect := []*regexp.Regexp{
+		regexp.MustCompile(`(?m)Usage:\s+kubectl krew`),
+		regexp.MustCompile(`(?m)Use "kubectl krew`),
+	}
+
+	for _, e := range expect {
+		if !e.MatchString(out) {
+			t.Errorf("output does not have matching string to pattern %s ; output=%s", e, out)
+		}
+	}
+}