Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

images/base: disable udev.service #1948

Merged
merged 1 commit into from
Jan 20, 2021
Merged

images/base: disable udev.service #1948

merged 1 commit into from
Jan 20, 2021

Conversation

AkihiroSuda
Copy link
Member

Discussed in #1935 (comment)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 1, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @AkihiroSuda. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 1, 2020
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 1, 2020
@AkihiroSuda AkihiroSuda mentioned this pull request Dec 1, 2020
Merged
@AkihiroSuda AkihiroSuda force-pushed the disable-udev branch 4 times, most recently from 79b9b9e to 12fd3be Compare December 3, 2020 08:32
@AkihiroSuda
Copy link
Member Author

Failure of Podman CI seems unrelated

• Waiting ≤ 1m0s for control-plane = Ready ⏳  ...
 ✓ Waiting ≤ 1m0s for control-plane = Ready ⏳
 • Ready after 28s 💚
ERROR: failed to create cluster: network details should only be one line, got 0 lines

@AkihiroSuda
Copy link
Member Author

@BenTheElder PTAL

@BenTheElder
Copy link
Member

BenTheElder commented Dec 3, 2020 via email

@aojea
Copy link
Contributor

aojea commented Dec 3, 2020

podman CI is indeed broken atm (breaking podman changes...) aojea is on it

fixed by #1790

@BenTheElder
Copy link
Member

fix is merged now, but I'm off to exercise the pup. will review tonight.

also, github actions requires that we rebase this PR to pick up the fix, unlike prow 😞

@AkihiroSuda
Copy link
Member Author

thanks, rebased

@BenTheElder
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 4, 2020
@BenTheElder
Copy link
Member

/lgtm
/approve
/hold
(will do follow-up in the morning and get this in)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 4, 2020
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 4, 2020
@AkihiroSuda
Copy link
Member Author

ping maintainers

@aojea
Copy link
Contributor

aojea commented Dec 16, 2020

@BenTheElder we need to bump the image on #1979 , so I think we should have this in before that lands

@BenTheElder
Copy link
Member

I did the bump push. I did not add it to the PR because everything is on hold pending the fact that we seem to have broken kind in github actions.
When we get sufficient time to resolve that we can move with more changes.

@BenTheElder
Copy link
Member

#1969 should be resolved, finally 🤞

@AkihiroSuda
images/base: disable udev.service
42761be 
Discussed in kubernetes-sigs#1935 (comment)

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@AkihiroSuda
Copy link
Member Author

rebased

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 20, 2021
@BenTheElder
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 20, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AkihiroSuda, BenTheElder

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BenTheElder BenTheElder merged commit a64ec5d into kubernetes-sigs:master Jan 20, 2021
@BenTheElder BenTheElder mentioned this pull request Jan 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aojea aojea Awaiting requested review from aojea

@krzyzacy krzyzacy Awaiting requested review from krzyzacy

Assignees

@BenTheElder BenTheElder

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AkihiroSuda @k8s-ci-robot @BenTheElder @aojea