Documentation bug in "using-wsl2.md"

[alandixon]

Sorry, not really a bug, but the best label fit available.

Documentation bug in kind/site/content/docs/user/using-wsl2.md
(https://github.com/kubernetes-sigs/kind/blob/master/site/content/docs/user/using-wsl2.md)

At the bottom of the document in the paragraph "Helpful Tips for WSL2"
Your proposed approach "wsl distro --shutdown" throws an error: "/bin/bash: distro: command not found".

You shutdown a distro with
wsl --shutdown <distro>
i.e. the parameter order needs to be reversed.
This is incorrect, see my comment below

[BenTheElder]

Would you mind sending a PR? WSL2 support is fully community maintained, none of the maintainers are using it currently.

[aojea]

/good-first-issue
/help wanted
@alandixon should I assign it to you?

[k8s-ci-robot]

@aojea:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue
/help wanted
@alandixon should I assign it to you?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[alandixon]

Hi Benjamin, Sorry, PR? Alan

…

On Mon, 14 Dec 2020 at 18:17, Benjamin Elder ***@***.***> wrote: Would you mind sending a PR? WSL2 support is fully community maintained, none of the maintainers are using it currently. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1977 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADERGDGB7OHWT4APULWR5ETSUZJCJANCNFSM4U27K7BA> .

[alandixon]

Ah yes, good idea, assign it to me, I didn't think of that!

…

On Tue, 15 Dec 2020 at 14:50, Antonio Ojea ***@***.***> wrote: /good-first-issue /help wanted @alandixon <https://github.com/alandixon> should I assign it to you? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1977 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADERGDHJQKO2TBFDBE2VBXTSU5ZUTANCNFSM4U27K7BA> .

[aojea]

/assign @alandixon

[BenTheElder]

Er sorry for the jargon / acronym! Pull request, a patch on GitHub 😅
If not, we can get to it ourselves eventually as well, docs are important! Currently chasing #1969

[gunadhya]

Hi @aojea, I'd like to fix this documentaion bug.

[aojea]

@gunadhya go for it, worst case we have 2 PRS ...

[aojea]

is there any person using WSL that can confirm what is the right command?
This issue says that --shutdown doesn't accept any argument microsoft/WSL#4539

[alandixon]

The fix is in my original comment.
This was assigned to me but I was completely unable to push the change back up - it kept giving me an error.
I followed the instructions about signing the CNCF CLA etc. but gave up when that didn't work - it all seemed a bit much for a tiny doc change.
Sorry, I should have unassigned myself earlier - @gunadhya feel free to take this.

[aojea]

Thanks Alan

[alandixon]

After all that, I got it wrong anyway :(
Running wsl -? to see the available commands gives

    --shutdown
        Immediately terminates all running distributions and the WSL 2 lightweight utility virtual machine.
    --terminate, -t <Distro>
        Terminates the specified distribution.

i.e. it's --terminate to shutdown a specific distro, not --shutdown

[aojea]

why does this work then?
#1994 (comment)