Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Supporting new topologySpread scheduling constraints #580

Closed
wants to merge 16 commits into from

Conversation

sadath-12
Copy link
Contributor

Fixes #430

Description

How was this change tested?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sadath-12 and others added 7 commits October 3, 2023 18:18
…tPolicy: Always

Signed-off-by: sadath-12 <sadathsadu2002@gmail.com>
Signed-off-by: vboxuser <vboxuser@ubuntu.myguest.virtualbox.org>
Signed-off-by: sadath-12 <sadathsadu2002@gmail.com>
Signed-off-by: sadath-12 <sadathsadu2002@gmail.com>
Signed-off-by: syedsadath-17 <90619459+sadath-12@users.noreply.github.com>
Signed-off-by: syedsadath-17 <90619459+sadath-12@users.noreply.github.com>
Signed-off-by: syedsadath-17 <90619459+sadath-12@users.noreply.github.com>
@sadath-12 sadath-12 requested a review from a team as a code owner October 9, 2023 16:36
@sadath-12 sadath-12 changed the title Sadath dev 3 feat: Supporting new topologySpread scheduling constraints Oct 9, 2023
Copy link
Member

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I can tell we didn't update this to use the new nodeTaintsPolicy. I think that's fine if you want to scope down this PR. I'd just specify what you are trying to add in the title and description

@jonathan-innis
Copy link
Member

I'd maybe consider moving this PR back in draft. From what I can tell this PR isn't ready for review yet (doesn't have all the test cases yet, doesn't completely resolves the issue that is linked to it). If we want to scope down the PR, that's fine, I'd just include detail of that in the description and make sure that we don't have "Fixes ..." in the description so that we don't close the issue until it's truly done.

@sadath-12
Copy link
Contributor Author

sadath-12 commented Oct 13, 2023

thank you @jonathan-innis , ill make this pr ready to merge in my upcoming commits

sadath-12 and others added 8 commits October 14, 2023 11:15
Signed-off-by: sadath-12 <sadathsadu2002@gmail.com>
Signed-off-by: sadath-12 <sadathsadu2002@gmail.com>
Signed-off-by: sadath-12 <sadathsadu2002@gmail.com>
Signed-off-by: sadath-12 <sadathsadu2002@gmail.com>
Signed-off-by: sadath-12 <sadathsadu2002@gmail.com>
Signed-off-by: sadath-12 <sadathsadu2002@gmail.com>
@sadath-12
Copy link
Contributor Author

Holding this pr for a while

Copy link

github-actions bot commented Nov 4, 2023

This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 4, 2023
@github-actions github-actions bot closed this Nov 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/closed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support new topologySpread scheduling constraints
2 participants