-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Supporting new topologySpread scheduling constraints #580
Conversation
…tPolicy: Always Signed-off-by: sadath-12 <sadathsadu2002@gmail.com>
Signed-off-by: vboxuser <vboxuser@ubuntu.myguest.virtualbox.org>
Signed-off-by: sadath-12 <sadathsadu2002@gmail.com>
Signed-off-by: sadath-12 <sadathsadu2002@gmail.com>
Signed-off-by: syedsadath-17 <90619459+sadath-12@users.noreply.github.com>
Signed-off-by: syedsadath-17 <90619459+sadath-12@users.noreply.github.com>
Signed-off-by: syedsadath-17 <90619459+sadath-12@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I can tell we didn't update this to use the new nodeTaintsPolicy
. I think that's fine if you want to scope down this PR. I'd just specify what you are trying to add in the title and description
I'd maybe consider moving this PR back in draft. From what I can tell this PR isn't ready for review yet (doesn't have all the test cases yet, doesn't completely resolves the issue that is linked to it). If we want to scope down the PR, that's fine, I'd just include detail of that in the description and make sure that we don't have "Fixes ..." in the description so that we don't close the issue until it's truly done. |
thank you @jonathan-innis , ill make this pr ready to merge in my upcoming commits |
Signed-off-by: sadath-12 <sadathsadu2002@gmail.com>
Signed-off-by: sadath-12 <sadathsadu2002@gmail.com>
Signed-off-by: sadath-12 <sadathsadu2002@gmail.com>
Signed-off-by: sadath-12 <sadathsadu2002@gmail.com>
Signed-off-by: sadath-12 <sadathsadu2002@gmail.com>
Signed-off-by: sadath-12 <sadathsadu2002@gmail.com>
Holding this pr for a while |
This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity. |
Fixes #430
Description
How was this change tested?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.