-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mgmt kubeconfig flag #8
Mgmt kubeconfig flag #8
Conversation
thanks @daimaxiaxie , i will need some time to study this, but in general i would like to defer on adding the extra clients until we have a clearer picture of how deployment will work. i'm also not sure about the client we will pass to the karpenter core for reading the nodes and pods. i think this is a good start though. |
@daimaxiaxie the one thing i would like to see in this PR is a default mechanism so that if the user does not specify the |
It should be so. |
this looks great, thanks for the update. i'm going to test it locally and if everything works as expected i will merge this week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i have a minor request to change the flag text, but otherwise i think this is working as expected.
i am continuing to run some local tests.
Co-authored-by: Michael McCune <msm@opbstudios.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the updates!
ClusterAPINodeClass in work cluster, Machine/MachineDeployment in manager cluster.