Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mgmt kubeconfig flag #8

Merged
merged 7 commits into from
Jul 18, 2024

Conversation

daimaxiaxie
Copy link
Contributor

+--------+                         +-----------+             +----------+
|  mgmt  |                         |           |             | workload |
|        |  cluster-api-kubeconfig | --------- | kubeconfig  |          |
|        |<------------------------+ karpenter +------------>|          |
+--------+                         +-----------+             +----------+

ClusterAPINodeClass in work cluster, Machine/MachineDeployment in manager cluster.

@elmiko
Copy link
Collaborator

elmiko commented Jun 28, 2024

thanks @daimaxiaxie , i will need some time to study this, but in general i would like to defer on adding the extra clients until we have a clearer picture of how deployment will work. i'm also not sure about the client we will pass to the karpenter core for reading the nodes and pods.

i think this is a good start though.

@elmiko
Copy link
Collaborator

elmiko commented Jul 9, 2024

@daimaxiaxie the one thing i would like to see in this PR is a default mechanism so that if the user does not specify the --cluster-api-kubeconfig it uses the original --kubeconfig (or service account credentials).

@daimaxiaxie
Copy link
Contributor Author

It should be so.

@elmiko
Copy link
Collaborator

elmiko commented Jul 10, 2024

this looks great, thanks for the update. i'm going to test it locally and if everything works as expected i will merge this week.

Copy link
Collaborator

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i have a minor request to change the flag text, but otherwise i think this is working as expected.

i am continuing to run some local tests.

pkg/operator/options/options.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the updates!

@elmiko elmiko merged commit e3c435e into kubernetes-sigs:main Jul 18, 2024
1 check passed
@daimaxiaxie daimaxiaxie deleted the mgmt-kubeconfig-flag branch July 19, 2024 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants