Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix schema #7

Merged
merged 3 commits into from
Jun 28, 2024
Merged

fix schema #7

merged 3 commits into from
Jun 28, 2024

Conversation

daimaxiaxie
Copy link
Contributor

fix schema

kube client get/list error

"error":"no kind is registered for the type v1beta1.MachineDeploymentList in scheme \"pkg/runtime/scheme.go:100\""

elmiko
elmiko reviewed Jun 28, 2024
View reviewed changes
Copy link
Collaborator

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @daimaxiaxie , i'm surprised it doesn't complain when the karpenter apis are removed. this generally looks good, i just have a couple nits about the naming.

pkg/apis/apis.go Outdated Show resolved Hide resolved
pkg/apis/apis.go Outdated Show resolved Hide resolved
elmiko
elmiko reviewed Jun 28, 2024
View reviewed changes
Copy link
Collaborator

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect, thank you!

@elmiko elmiko merged commit cc6f65c into kubernetes-sigs:main Jun 28, 2024
1 check passed
@daimaxiaxie daimaxiaxie deleted the fix-schema branch June 28, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elmiko elmiko elmiko left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daimaxiaxie @elmiko