-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Almalinux 9 image on Outscale. #1670
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @etchevef! |
Hi @etchevef. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Hmm... this would introduce yet another OS we'd need to support in image-builder (and we already struggle with the current list of OS's 😅) |
I'm personally happy for it to go in but it'd have to be on the understanding we can't test or guarantee it. It'd be on someone from/using Outscale to test this with each release as we don't have the capacity to support it. As Marcus said, the list of OS's is already large and we struggle to support them all as it stands. |
I'm on the fence: I love seeing new platforms and OS distros supported, but our test coverage is meager and many of the make targets are probably not working. Ideally everything would be tested by CI, or at least we'd have active reviewers in each area. Is there someone else who works with Outscale we could run this by? I'd like to allow it to merge and mark it as "unsupported" in docs, but TBH that's a slippery slope because in practice that's true for most targets. |
@etchevef Hi @mboersma @jsturtevant @drew-viles @AverageMarcus |
Please reach out in the image-builder Slack channel where it will be easier to discuss :) |
Change description
This PR adds the necessaries to build an image based on almalinux 9 on Outscale. It also bump the outscale packer module from 1.2.0 to 1.3.0 (latest).
Additional context
The resulting image has been tested and works for me (No reason why not, it uses redhat based playbooks from other cloud provider) but won't be supported by outscale (I suppose). Proposing the PR just in case.