Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Almalinux 9 image on Outscale. #1670

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

etchevef
Copy link

Change description

This PR adds the necessaries to build an image based on almalinux 9 on Outscale. It also bump the outscale packer module from 1.2.0 to 1.3.0 (latest).

Additional context

The resulting image has been tested and works for me (No reason why not, it uses redhat based playbooks from other cloud provider) but won't be supported by outscale (I suppose). Proposing the PR just in case.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign averagemarcus for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 15, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @etchevef!

It looks like this is your first PR to kubernetes-sigs/image-builder 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/image-builder has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 15, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @etchevef. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 15, 2025
@AverageMarcus
Copy link
Member

Hmm... this would introduce yet another OS we'd need to support in image-builder (and we already struggle with the current list of OS's 😅)
I'm not gonna hard-block this but I'd like to get the thoughts from the other maintainers before we proceed.
/cc @mboersma @jsturtevant @drew-viles

@drew-viles
Copy link
Contributor

drew-viles commented Jan 16, 2025

I'm personally happy for it to go in but it'd have to be on the understanding we can't test or guarantee it. It'd be on someone from/using Outscale to test this with each release as we don't have the capacity to support it. As Marcus said, the list of OS's is already large and we struggle to support them all as it stands.

@mboersma
Copy link
Contributor

I'm on the fence: I love seeing new platforms and OS distros supported, but our test coverage is meager and many of the make targets are probably not working. Ideally everything would be tested by CI, or at least we'd have active reviewers in each area.

Is there someone else who works with Outscale we could run this by? I'd like to allow it to merge and mark it as "unsupported" in docs, but TBH that's a slippery slope because in practice that's true for most targets.

@andrewlukoshko
Copy link

@etchevef
osc-almaLinux-9-2024 should be renamed to osc-almalinux-9, AlmaLinux doesn't have year in its version.

Hi @mboersma @jsturtevant @drew-viles @AverageMarcus
AlmaLinux OS Architect and Engineering Steering Committee member here.
We'd love to help with AlmaLinux support in this repository. Not only for Outscale but also for many other targets.
Please tell me how we can help with this. Thanks.

@AverageMarcus
Copy link
Member

@etchevef osc-almaLinux-9-2024 should be renamed to osc-almalinux-9, AlmaLinux doesn't have year in its version.

Hi @mboersma @jsturtevant @drew-viles @AverageMarcus AlmaLinux OS Architect and Engineering Steering Committee member here. We'd love to help with AlmaLinux support in this repository. Not only for Outscale but also for many other targets. Please tell me how we can help with this. Thanks.

Please reach out in the image-builder Slack channel where it will be easier to discuss :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants