-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(containerd): Support containerd 2.0 #1658
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: ffais <ffais@fbk.eu>
Signed-off-by: ffais <ffais@fbk.eu>
Signed-off-by: ffais <ffais@fbk.eu>
Welcome @ffais! |
Hi @ffais. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: ffais <ffais@fbk.eu>
…pported providers Signed-off-by: ffais <ffais@fbk.eu>
Signed-off-by: ffais <ffais@fbk.eu>
/ok-to-test |
Signed-off-by: ffais <ffais@fbk.eu>
/test pull-azure-sigs |
1 similar comment
/test pull-azure-sigs |
Azure tests keep failing randomly, I did some tests locally and everything works perfectly. Could it be related to this #1656 ? |
In the last case, it was this: �[0;32m azure-arm.sig-ubuntu-2404-gen2: TASK [kubernetes : Install Kubernetes] *****************************************�[0m
�[0;32m azure-arm.sig-ubuntu-2404-gen2: fatal: [default]: FAILED! => {"cache_update_time": 1735390377, "cache_updated": false, "changed": false, "msg": "'/usr/bin/apt-get -y -o \"Dpkg::Options::=--force-confdef\" -o \"Dpkg::Options::=--force-confold\" install 'kubelet=1.30.5-1.1' 'kubeadm=1.30.5-1.1' 'kubectl=1.30.5-1.1' 'kubernetes-cni=1.4.0-1.1'' failed: E: Could not get lock /var/lib/dpkg/lock-frontend. It is held by process 18541 (apt)\nE: Unable to acquire the dpkg frontend lock (/var/lib/dpkg/lock-frontend), is another process using it?\n", "rc": 100, "stderr": "E: Could not get lock /var/lib/dpkg/lock-frontend. It is held by process 18541 (apt)\nE: Unable to acquire the dpkg frontend lock (/var/lib/dpkg/lock-frontend), is another process using it?\n", "stderr_lines": ["E: Could not get lock /var/lib/dpkg/lock-frontend. It is held by process 18541 (apt)", "E: Unable to acquire the dpkg frontend lock (/var/lib/dpkg/lock-frontend), is another process using it?"], "stdout": "", "stdout_lines": []}�[0m
�[0;32m azure-arm.sig-ubuntu-2404-gen2:�[0m I've never seen an The failure in #1656 manifests at a higher level and fails all the builds, so I don't think this is related. :-| |
/test pull-azure-sigs |
1 similar comment
/test pull-azure-sigs |
/retest |
fmm 🤔 |
@sivchari Azure tests keeps failing randomly, I don't understand why! This time the job that failed was sig-azurelinux-3-gen2, with this error:
I've been using containerd 2.0 for about a month on azure using images created with image-builder without problems. PS: Support for version 3 of the containerd configuration has been introduced since the v1.17.4 release of nvidia-container-toolkit. This allows us to use containerd 2.0 with GPU nodes. |
@ffais |
Signed-off-by: ffais <ffais@fbk.eu>
@sivchari You're right, increasing the 'polling_duration_timeout' from 15 (default) to 60 minutes seems to fix the problem. |
517c67f
to
27d49a7
Compare
@ffais |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/assign @mboersma @AverageMarcus |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we do the change for all providers?
I can see e.g. images/capi/packer/ova/packer-node.json
is missng the runc and containerd change.
@chrischdi You're right, I missed it. |
Signed-off-by: ffais <ffais@fbk.eu>
New changes are detected. LGTM label has been removed. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Change description
The cri-containerd-*.tar.gz release bundles have been deprecated since containerd v1.6, and from containerd v2.0 this bundle is no longer available.
Related issues
GOSS log