Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing VirtualBox target #1436

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Removing VirtualBox target #1436

merged 1 commit into from
Apr 24, 2024

Conversation

knabben
Copy link
Member

@knabben knabben commented Mar 25, 2024

Change description

Removing VirtualBox target since its not being actively maintained, important to remove in order to cleanup the repository

Additional context

Used by sig-windows-dev-tools without any usage.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 25, 2024
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 25, 2024
@knabben knabben force-pushed the knabben/remove-vbox branch from 8e1f247 to 6f8edc6 Compare March 25, 2024 00:14
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 25, 2024
@knabben knabben force-pushed the knabben/remove-vbox branch from 6f8edc6 to 3561567 Compare March 25, 2024 00:15
@knabben knabben mentioned this pull request Mar 25, 2024
Merged
@jsturtevant
Copy link
Contributor

/lgtm
/hold
for a couple weeks incase there was someone who took a dependency that we are not aware of. I will post in slack for awareness

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 25, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 25, 2024
@AverageMarcus
Copy link
Member

/lgtm

@knabben
Copy link
Member Author

knabben commented Apr 24, 2024

@jsturtevant should this one go through? Is here for a month.

@jsturtevant
Copy link
Contributor

/hold cancel
/approve

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 24, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsturtevant

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2024
@k8s-ci-robot k8s-ci-robot merged commit 9e51e84 into kubernetes-sigs:main Apr 24, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsturtevant jsturtevant Awaiting requested review from jsturtevant

@kkeshavamurthy kkeshavamurthy Awaiting requested review from kkeshavamurthy

Assignees

@jsturtevant jsturtevant

@AverageMarcus AverageMarcus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@knabben @jsturtevant @AverageMarcus @k8s-ci-robot