Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the default namespace issue #150

Merged
merged 6 commits into from
Feb 15, 2024
Merged

Fixed the default namespace issue #150

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e998b16
Fixed the default namespace issue
Bharadwajshivam28 Feb 11, 2024
eaf9eb5
validating namespace
Bharadwajshivam28 Feb 11, 2024
9633196
used log instead of fmt
Bharadwajshivam28 Feb 11, 2024
4edca57
Moved calling of function from root.go
Bharadwajshivam28 Feb 13, 2024
7da6ba5
Passing mage test which was faling due to incorrect usage of Printf
Bharadwajshivam28 Feb 14, 2024
b3b74dd
formatted files to pass tests
Bharadwajshivam28 Feb 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions pkg/service/init.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,6 +323,12 @@ func RunE2E(clientset *kubernetes.Clientset) {
// Cleanup removes all resources created during E2E tests.
func Cleanup(clientset *kubernetes.Clientset) {
namespace := viper.GetString("namespace")

if namespace == "" {
Copy link
Contributor

@reetasingh reetasingh Feb 11, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Bharadwajshivam28 A cleaner solution would be to reuse the ValidateArgs method https://github.com/kubernetes-sigs/hydrophone/blob/main/pkg/common/args.go#L52. its currently validating multiple things. maybe we can introduce a new method for validating namespace?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay works for me... let me change it @reetasingh

defaultNamespace := "conformance"
fmt.Printf("No namespace provided, using default namespace: %s\n", defaultNamespace)
namespace = defaultNamespace
}

err := clientset.CoreV1().Pods(namespace).Delete(ctx, common.PodName, metav1.DeleteOptions{})
if err != nil {
Expand Down