Upgrading to go 1.22 + k8s 1.30 dependencies

[robscott]

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Kubernetes v1.30 was released today, this bumps dependencies to match.

Which issue(s) this PR fixes:
Fixes #2956

Does this PR introduce a user-facing change?:

Dependencies have been updated to use Go 1.22 and Kubernetes 1.30.

[howardjohn]

there's no need to require .2 (I think)

this is viral and will force all dependencies to do so as well

[robscott]

I think it's automatic now, go mod tidy will hardcode 1.22.0 if we just have 1.22 here. Maybe that's preferable? (x-ref https://github.com/kubernetes/kubernetes/blob/master/go.mod#L9)

[howardjohn]

yeah I would put 1.22.0.

1.22.2 says "you MUST have the .2 patch to use this as a library". Really the Go specifier should be the minimum version you support (though in practice this doesn't matter much since the go ecosystem is pretty good about updating)

[howardjohn]

Controversial...

https://twitter.com/liggitt/status/1780994018047840540
kubernetes/kubernetes#124385

[dprotaso]

Yeah I've complained here - golang/go#65847

[robscott]

It seems like upstream is moving to 1.22.2 for now (x-ref kubernetes/kubernetes#124386), will stick with this until a better option emerges.

[liggitt]

I closed kubernetes/kubernetes#124386 until we think through this more and left k/k at 1.22.0, xref kubernetes/kubernetes#124386 (comment)

[liggitt]

I'd recommend go 1.22.0 or whatever go dictates your minimum has to be ... including the patch means you won't fight go tooling, leaving it at the minimum patch in the minor means you are permissive to your downstreams and builders as possible

Building with go patch versions above the minimum works perfectly well (and you can actually put toolchain directives in the go.mod file to indicate you require building main packages in this module with a higher patch version if you want)

[robscott]

Updated to use 1.22.0, thanks everyone!

[howardjohn]

surprised this works since they don't support 1.30 yet and there were incompatible changes.. I guess we must not import some of those packages

[robscott]

Bumped back to v0.17.0 to allow dependent implementations to pick up newer changes from controller-runtime - no changes in either case from perspective of Gateway API directly.

[robscott]

Looks like any use of applyconfiguration-gen is broken until kubernetes/kubernetes#124371 merges (ideally in time for v1.30.1). That leaves us with a few not-great options:

1. Release RC1 without applyconfigurations
2. Release RC1 without k8s 1.30 + go 1.22
3. Wait for k8s v1.30.1 until releasing RC1

At this point, I'm thinking that if v1.30.1 is not ready (or close to ready) by the time we're ready to release RC1, we should move forward with option 1 with the idea that we might be able to add applyconfigurations back in before RC2 (cc @dprotaso).

[dprotaso]

The docker images need bumping to go 1.22 as well - see #2993

[robscott]

Looks like any use of applyconfiguration-gen is broken until kubernetes/kubernetes#124371 merges (ideally in time for v1.30.1). That leaves us with a few not-great options:

1. Release RC1 without applyconfigurations
2. Release RC1 without k8s 1.30 + go 1.22
3. Wait for k8s v1.30.1 until releasing RC1

Thanks to some clever hacks by @dprotaso, we've got a workaround that should work until the upstream fix is released in v1.30.1. This PR is ready for another round of review.

[robscott]

The docker images need bumping to go 1.22 as well - see #2993

Updated, thanks @dprotaso!

[dprotaso]

/retest

[shaneutt]

I think it would be nice if we could get this in for 1.1.

[robscott]

I think @k8s-ci-robot needs some help clearing the needs-rebase label,

/honk

[k8s-ci-robot]

@robscott:

In response to this:

I think @k8s-ci-robot needs some help clearing the needs-rebase label,

/honk

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: howardjohn, robscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [robscott]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[howardjohn]

/lgtm

[ryanaoleary]

Does this mean that the minimum required Kubernetes version for Gateway API v1.1+ is v1.30? or are the last 5 minor versions still supported?

[youngnick]

Still the last 5 minor versions, we're just using the 1.30+ dependencies, that's all. (I think we have upgraded since this PR as well).