Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Gateway to core reference from kinds #1223

Closed
wants to merge 1 commit into from

Conversation

rainest
Copy link
Contributor

@rainest rainest commented Jun 22, 2022

What type of PR is this?
/kind documentation
/kind api-change

What this PR does / why we need it:
Adds Gateway to the list of kinds ReferenceGrantFrom must support for core support

https://gateway-api.sigs.k8s.io/v1alpha2/references/spec/#gateway.networking.k8s.io/v1alpha2.SecretObjectReference states:

Note that when a namespace is specified, a ReferenceGrant object is required in the referent namespace to allow that namespace’s owner to accept the reference. See the ReferenceGrant documentation for details.
Support: Core

This indicates cross-namespace SecretObjectReferences are required for core support. This doesn't clarify how you should check their validity, though a Gateway ReferenceGrantFrom entry appears correct, as it's the only independent type that can include a SecretObjectReference (via Listener->GatewayTLSConfig). By extension, it appears you must support Gateways in addition to the currently listed Route types.

Does this PR introduce a user-facing change?:

NONE

Maybe? This seems like it was already implied, but just omitted from docs, and this is more a clarification point to say "yes, you should check for a Gateway from rule, not a GatewayTLSConfig from rule". I'm ambivalent as to whether this should instead be:

Added Gateway to the list of core required kinds in ReferenceGrantFrom

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 22, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @rainest. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested a review from jpeach June 22, 2022 18:37
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rainest
To complete the pull request process, please assign youngnick after the PR has been reviewed.
You can assign the PR to them by writing /assign @youngnick in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from youngnick June 22, 2022 18:37
@robscott
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 22, 2022
Add Gateway to the list of core kinds implementations must support in
ReferenceGrantFrom. Gateway Listener core support requires
implementations support references to TLS Secrets in other namespaces,
and these references require permission from a ReferenceGrant in the
target namespace.
@rainest rainest force-pushed the doc/gateway-core-ref branch from 51df76c to d6cca04 Compare June 22, 2022 22:03
@robscott
Copy link
Member

I thought this looked familiar... I think this is roughly the same as #1181, and my comment there applies here.

@rainest
Copy link
Contributor Author

rainest commented Jun 24, 2022

Closed in favor of 1181.

@rainest rainest closed this Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/documentation Categorizes issue or PR as related to documentation. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants