-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
recopy the v1beta1 types #1192
recopy the v1beta1 types #1192
Conversation
Signed-off-by: mehabhalodiya <mehabhalodiya@gmail.com>
Signed-off-by: mehabhalodiya <mehabhalodiya@gmail.com>
Signed-off-by: mehabhalodiya <mehabhalodiya@gmail.com>
Signed-off-by: mehabhalodiya <mehabhalodiya@gmail.com>
Signed-off-by: mehabhalodiya <mehabhalodiya@gmail.com> Rename files to reflect ReferencePolicy -> ReferenceGrant These were missed in kubernetes-sigs#1179 feat: introduce v1beta1 types Signed-off-by: mehabhalodiya <mehabhalodiya@gmail.com> recopy the v1beta1 types Signed-off-by: mehabhalodiya <mehabhalodiya@gmail.com> change package Signed-off-by: mehabhalodiya <mehabhalodiya@gmail.com>
…way-api into v1beta1-types
Thanks @mehabhalodiya! This LGTM, I think there are one or two more recent changes that may have been missed + we need to update CRD generation based on that. I'll make a follow up PR for those things, but I think we should get this in now. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mehabhalodiya, robscott The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: mehabhalodiya mehabhalodiya@gmail.com
What type of PR is this?
/kind feature
What this PR does / why we need it:
As suggested by @robscott, this is a follow-up PR on one of our last steps before the v1beta1 (v0.5.0) release.
The key is that we’d need
GatewayClass
,Gateway
, andHTTPRoute
type definitions inapis/v1beta1
in addition to the alpha directories they already exist in.Which issue(s) this PR fixes:
Fixes #1041
Does this PR introduce a user-facing change?: