-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish policy on using generics in gateway-api #1388
Comments
@keithmattix: GuidelinesPlease ensure that the issue body includes answers to the following questions:
For more details on the requirements of such an issue, please see here and ensure that they are met. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I would like to work on this issue. But would need guidance as well |
Refs https://github.com/kubernetes/community/blob/master/sig-architecture/generics.md for the upstream Kubernetes policy, and kubernetes/kubernetes#106846 as a specific attempt at introducing generics in a meaningful way. FWIW I did previously introduce some trivial usage of generics in #1081 |
We have a upstream Kubernetes policy in place for using generics, I think we should mirror it for single source of truth |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
Where are we at with this? |
What would you like to be added:
With generics shipping in go1.18, the gateway-api project needs to have some kind of policy around when and how generics should be used. If upstream Kubernetes has a policy, we likely need to mirror it. If further discussion is needed, please use GitHub Discussions and/or Slack to engage members of the community.
Why this is needed:
Generics are a very new Go feature, and the implications of using them in a large codebase/project are unknown. Thus, it will be useful for contributors to have guidelines for how to use generics in the gateway-api codebase.
/good-first-issue
The text was updated successfully, but these errors were encountered: