Merge pull request #964 from robscott/reference-policy-fix

Fixing bug where namespace could be unspecified in ReferencePolicy
kubernetes-sigs · Dec 14, 2021 · 1deb7bc · 1deb7bc
2 parents 9a916f7 + 07a5f2a
commit 1deb7bc
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 1 deletion.
diff --git a/apis/v1alpha2/referencepolicy_types.go b/apis/v1alpha2/referencepolicy_types.go
@@ -104,7 +104,7 @@ type ReferencePolicyFrom struct {
 	// Namespace is the namespace of the referent.
 	//
 	// Support: Core
-	Namespace Namespace `json:"namespace,omitempty"`
+	Namespace Namespace `json:"namespace"`
 }
 
 // ReferencePolicyTo describes what Kinds are allowed as targets of the

diff --git a/config/crd/experimental/gateway.networking.k8s.io_referencepolicies.yaml b/config/crd/experimental/gateway.networking.k8s.io_referencepolicies.yaml
diff --git a/config/crd/stable/gateway.networking.k8s.io_referencepolicies.yaml b/config/crd/stable/gateway.networking.k8s.io_referencepolicies.yaml
diff --git a/hack/invalid-examples/v1alpha2/referencepolicy/missing-ns.yaml b/hack/invalid-examples/v1alpha2/referencepolicy/missing-ns.yaml
@@ -0,0 +1,11 @@
+apiVersion: gateway.networking.k8s.io/v1alpha2
+kind: ReferencePolicy
+metadata:
+  name: missing-ns
+spec:
+  to:
+  - group: ""
+    kind: "Service"
+  from:
+  - group: "gateway.networking.k8s.io"
+    kind: "HTTPRoute"