-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(Azure DNS): fix tutorial about Azure identity variables #4899
docs(Azure DNS): fix tutorial about Azure identity variables #4899
Conversation
The committers listed above are authorized under a signed CLA. |
Welcome @EvanSchallerer! |
Hi @EvanSchallerer. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/retitle docs(Azure DNS): fix tutorial about Azure identity variables |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mloiseleur The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Fixes incorrect property name in the Azure DNS tutorial documentation and updates the description for this property.
Note that the workload identity configuration uses
aadClientId
while the managed identity workload configuration usesuserAssignedIdentityID
when retrieving the client ID from the azure.json file. This was incorrectly documented as using theuserAssignedIdentityID
for both configuration extensions.Fixes #4898
Checklist