feat[chart]: Update to ExternalDNS v0.12.0

[vojtechmares]

Updating Helm chart to ExternalDNS v0.12.0

I've inspired myself with last commit updating the helm chart from v0.10.2 to v0.11.0 (a26ac53)

Closes #2776

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: vojtechmares / name: Vojtech Mares (9e0288c)

[k8s-ci-robot]

Welcome @vojtechmares!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[stevehipwell]

@vojtechmares I've got #2776 to release v0.12.0 assigned to myself as there are a couple of lifecycle changes I was planning on making as part of the release.

I'll make my changes and if you can rebase on top of them, once merged, your PR can do the release.

[vojtechmares]

@stevehipwell ok. Sorry I did not check the issue, I am working and I just checked if there is a release and since there wasn't one, I've created a PR.

Can I help with the lifecycle changes?

EDIT: Sorry for not checking the issues beforehand. Yet I guess in this case it is not a big deal.

[vojtechmares]

@stevehipwell rebased ontomaster as discussed after merge of #2807.

[stevehipwell]

Thanks @vojtechmares, could you look at the changes I've suggested?

[vojtechmares]

@stevehipwell I've force-pushed again with suggested changes.

[stevehipwell]

Thanks @vojtechmares.

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stevehipwell, vojtechmares

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• charts/OWNERS [stevehipwell]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[stevehipwell]

/ok-to-test

[stevehipwell]

@vojtechmares could you add a closes statement to the PR description for #2776?

[stevehipwell]

@seanmalloy could you enable the tests to run? For the record I was expecting adding ok-to-test to do this (as I think it does in Metrics Server).

[vojtechmares]

@stevehipwell done. Added to PR desc.

[seanmalloy]

@seanmalloy could you enable the tests to run? For the record I was expecting adding ok-to-test to do this (as I think it does in Metrics Server).

@stevehipwell I've approved the test run. For reference this repo uses GitHub Actions, so adding the ok-to-test label doesn't work in this repo.

[stevehipwell]

@seanmalloy I'd have thought the k8s-ci-robot could automate it? AFAIK this approval was a recent GitHub actions change introduced to stop the malicious use of compute. Any suggestions for where to ask about this?

[seanmalloy]

@seanmalloy I'd have thought the k8s-ci-robot could automate it? AFAIK this approval was a recent GitHub actions change introduced to stop the malicious use of compute. Any suggestions for where to ask about this?

@stevehipwell as far as I know the CI robot doesn't do this. Seems like a good feature to add to the robot.

[vojtechmares]

Hello @seanmalloy, can you review this PR please?

[seanmalloy]

/lgtm

[Hokwang]

@vojtechmares
@seanmalloy
Hi, please check GitHub Actions > Release chart, there was an error, chart v1.10.0 didn't released.

[stevehipwell]

Thanks for spotting this @Hokwang, the CHANGELOG item was added but the release version wasn't set. I've opened #2856 which should release the chart when merged.