-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add Kubernetes compatibility table #2404
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @agaudreault-jive! |
I signed it |
/assign @Raffo |
/assign @stevehipwell |
@agaudreault-jive thanks for the PR and the thought you've given but the FYI the correct pattern for a release line constraint is |
kubeVersion
information
@Raffo this is no longer a chart PR, so back to you. FWIW I think this change would be useful. |
Thank you so much, this makes totally sense. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: agaudreault-jive, Raffo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
With the changes made in #2281, It breaks the backward compatibility to k8s 1.18. I think this field could be used to indicates that the chart now with default
appVersion: 0.10.0
only works with k8s version >= 1.19.0.Fixes #ISSUE
Checklist