-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
External-DNS: NodePort must not publish not ready pods #2704
Comments
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
I'm having the same problem |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close not-planned |
@k8s-triage-robot: Closing this issue, marking it as "Not Planned". In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/reopen I provide a fix for that |
@nefelim4ag: Reopened this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close not-planned |
@k8s-triage-robot: Closing this issue, marking it as "Not Planned". In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
fix: nodePort #2704 - publish ready endpoints
What happened:
NodePort Traffic policy: Local
Service with NodePort correctly update endpoints and does not try to publish not ready pods
ExternalDNS use internal logic to find pods by selector labels (instead of reading endpoints object) and only checks state isRunning (
external-dns/source/service.go
Line 568 in 0bf5fae
(Bad behavior: kubernetes/client-go#815)
What you expected to happen:
When I try to remove the pod and its moves to terminate state, external-dns that watching NodePort service will stop publishing node with the pod, not in a ready state.
Looks like we need additionally check pods by IsPodReady()
How to reproduce it (as minimally and precisely as possible):
Create service with NodePort type and with traffic policy Local pointing to some pods, add some lifecycle preStop look like
sleep 60
, after that delete pod and look at external-dns - it still publishes pod in terminating state.Environment:
external-dns --version
): 0.11The text was updated successfully, but these errors were encountered: