Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding file ADOPTERS.md #285

Merged
merged 6 commits into from
Jul 2, 2023
Merged

Adding file ADOPTERS.md #285

merged 6 commits into from
Jul 2, 2023

Conversation

vladimirvivien
Copy link
Contributor

Adding file ADOPTERS.md and its first adopter.

Fixes #215

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/testing Categorizes an issue or PR as relevant to SIG Testing. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 23, 2023
@vladimirvivien
Copy link
Contributor Author

@harshanarayana PTAL

harshanarayana
harshanarayana reviewed Jun 23, 2023
View reviewed changes
Copy link
Contributor

@harshanarayana harshanarayana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vladimirvivien Thanks for adding this one. Been thinking about this for a while now.

Left a few minor tweaks.

ADOPTERS.md Outdated Show resolved Hide resolved
ADOPTERS.md Outdated Show resolved Hide resolved
ADOPTERS.md Outdated Show resolved Hide resolved
@negz
Copy link
Contributor

negz commented Jun 24, 2023

LGTM on behalf of @crossplane. 🙂

Someone shared this query with me, which I found helpful to get a sense of how widely used the framework is:

https://github.com/search?type=code&q=lang%3Ago++NOT+repo%3Akubernetes-sigs%2Fe2e-framework+NOT+is%3Afork+%22sigs.k8s.io%2Fe2e-framework%22&p=2

@harshanarayana
Copy link
Contributor

@negz That is a pretty nifty query. Thanks for the link.

maruina
maruina reviewed Jun 29, 2023
View reviewed changes
ADOPTERS.md Show resolved Hide resolved
vladimirvivien and others added 5 commits July 1, 2023 10:15
@vladimirvivien @harshanarayana
Update ADOPTERS.md
9b424b2 
Co-authored-by: Harsha Narayana <harsha2k4@gmail.com>
@vladimirvivien @harshanarayana
Update ADOPTERS.md
19f7618 
Co-authored-by: Harsha Narayana <harsha2k4@gmail.com>
@vladimirvivien @harshanarayana
Update ADOPTERS.md
838547f 
Co-authored-by: Harsha Narayana <harsha2k4@gmail.com>
@vladimirvivien @maruina
Update ADOPTERS.md
7c862d8 
Co-authored-by: Matteo Ruina <matteo.ruina@gmail.com>
@vladimirvivien
Added GitHub query
1d0c6ae
vladimirvivien
vladimirvivien commented Jul 1, 2023
View reviewed changes
Copy link
Contributor Author

@vladimirvivien vladimirvivien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@harshanarayana @maruina @negz I updated the info you provided. PTAL.

@harshanarayana
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 2, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshanarayana, vladimirvivien

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [harshanarayana,vladimirvivien]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 5b42fd2 into kubernetes-sigs:main Jul 2, 2023
@harshanarayana harshanarayana mentioned this pull request Aug 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maruina maruina maruina left review comments

@harshanarayana harshanarayana harshanarayana left review comments

@ShwethaKumbla ShwethaKumbla Awaiting requested review from ShwethaKumbla

Assignees

@harshanarayana harshanarayana

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add an ADOPTERS.md page
5 participants
@vladimirvivien @negz @harshanarayana @k8s-ci-robot @maruina