add description feature to test tables #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: harshanarayana The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
approved
=== RUN TestTableDriven
=== RUN TestTableDriven/Random_numbers
=== RUN TestTableDriven/Random_numbers/testWithDescription
=== RUN TestTableDriven/Random_numbers/less_than_equal_64
=== RUN TestTableDriven/Random_numbers/more_than_than_equal_128
=== RUN TestTableDriven/Random_numbers/Assessment-3
/Users/harshnar/Work/Tesseract/Maglev/mks/k8s/e2e-framework/examples/table/env.go:450: Failed Executing Test: This is an example of how to create a test with description
=== RUN TestTableDriven/Feature-2
=== RUN TestTableDriven/Feature-2/A_simple_feature
--- FAIL: TestTableDriven (0.00s)
--- FAIL: TestTableDriven/Random_numbers (0.00s)
--- FAIL: TestTableDriven/Random_numbers/testWithDescription (0.00s)
--- PASS: TestTableDriven/Random_numbers/less_than_equal_64 (0.00s)
--- PASS: TestTableDriven/Random_numbers/more_than_than_equal_128 (0.00s)
--- PASS: TestTableDriven/Random_numbers/Assessment-3 (0.00s)
--- PASS: TestTableDriven/Feature-2 (0.00s)
--- PASS: TestTableDriven/Feature-2/A_simple_feature (0.00s)
FAIL
FAIL sigs.k8s.io/e2e-framework/examples/table 1.218sExample of test description being logged as part of the failure. |
negz
reviewed
Jun 24, 2023
There was a problem hiding this comment.
Thanks for tackling this @harshanarayana! I left some thoughts.
k8s-ci-robot
added
size/L
harshanarayana
force-pushed
the
enable-test-descriptions
branch
from
aca984c to
e73116c
Compare
There was a problem hiding this comment.
This is great @harshanarayana.
I think this is enough for now. If someone asks for filtering based on description that can be added later.
|
@vladimirvivien If you are good with these changes, we can get this one merged? |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable Test Table Description capabilities
Closes #277