Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation about passing custom flags #203

Merged
merged 1 commit into from
Feb 17, 2023
Merged

Add documentation about passing custom flags #203

merged 1 commit into from
Feb 17, 2023

Conversation

maruina
Copy link
Contributor

@maruina maruina commented Feb 13, 2023

Fix #202

@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Feb 13, 2023
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 13, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @maruina. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 13, 2023
@maruina maruina force-pushed the custom-flags-doc branch 3 times, most recently from 1cdca78 to 2d86c18 Compare February 16, 2023 22:29
vladimirvivien
vladimirvivien approved these changes Feb 17, 2023
View reviewed changes
Copy link
Contributor

@vladimirvivien vladimirvivien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 17, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maruina, vladimirvivien

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 17, 2023
@harshanarayana
Copy link
Contributor

/ok-to-test
/retest

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 17, 2023
harshanarayana
harshanarayana reviewed Feb 17, 2023
View reviewed changes
examples/custom_flags/custom_flags_test.go Outdated

func TestMain(m *testing.M) {
flag.StringVar(&myCustomFlag, "my-custom-flag", "", "my custom flag for my tests")
// create config from flags (always in TestMain because it calls
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TestMain or init handler of the package. Both will do, But should be done before the envconf.NewFromFlags() is called. That is all. Mind updating the comment here ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Do you also want me to update

e2e-framework/examples/flags/flags_test.go

Line 58 in db4e9fe

// create config from flags (always in TestMain because it calls flag.Parse())
since I copied from that?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that is fine. This is mostly to do with adding the new Flag bit.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 17, 2023
@harshanarayana
Copy link
Contributor

/lgtm

/assign @vladimirvivien

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 17, 2023
@k8s-ci-robot k8s-ci-robot merged commit 8153898 into kubernetes-sigs:main Feb 17, 2023
@vladimirvivien
Copy link
Contributor

/approve

@maruina maruina deleted the custom-flags-doc branch February 17, 2023 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshanarayana harshanarayana harshanarayana left review comments

@vladimirvivien vladimirvivien vladimirvivien approved these changes

@cpanato cpanato Awaiting requested review from cpanato

Assignees

@vladimirvivien vladimirvivien

@harshanarayana harshanarayana

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use custom flags
4 participants
@maruina @k8s-ci-robot @harshanarayana @vladimirvivien