-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ported critest to Windows #430
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Check CLA |
@SaswatB Thanks for the great work. I'm concerned it's hard to maintain with current implementation, as it defines many different consts for Windows/Linux in same file. For such cases, it's preferred to define them in different platform-specific files and keep using same variable name. |
Thanks of cleaning up the consts. Could you rebase the PR, squash the commits and sign CLA? |
d3dff03
to
a042a6c
Compare
/check-cla |
/check-cla |
@SaswatB Travis is still failing. Could you fix the validation errors? |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: feiskyer, SaswatB The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Port of all applicable tests to Windows.
Supports Windows containers and Linux containers on Windows.
Signed-off-by: Saswat Bhattacharya sabhatta@microsoft.com