Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ported critest to Windows #430

Merged
merged 1 commit into from
Jan 31, 2019
Merged

Conversation

SaswatB
Copy link
Contributor

@SaswatB SaswatB commented Jan 25, 2019

Port of all applicable tests to Windows.
Supports Windows containers and Linux containers on Windows.

Signed-off-by: Saswat Bhattacharya sabhatta@microsoft.com

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 25, 2019
@SaswatB
Copy link
Contributor Author

SaswatB commented Jan 25, 2019

Check CLA

images/image-test-win/build.ps1 Outdated Show resolved Hide resolved
pkg/validate/image.go Outdated Show resolved Hide resolved
pkg/validate/networking.go Outdated Show resolved Hide resolved
pkg/validate/networking.go Outdated Show resolved Hide resolved
pkg/validate/networking.go Outdated Show resolved Hide resolved
pkg/validate/streaming.go Outdated Show resolved Hide resolved
@feiskyer
Copy link
Member

feiskyer commented Jan 28, 2019

@SaswatB Thanks for the great work. I'm concerned it's hard to maintain with current implementation, as it defines many different consts for Windows/Linux in same file. For such cases, it's preferred to define them in different platform-specific files and keep using same variable name.

@feiskyer
Copy link
Member

Thanks of cleaning up the consts. Could you rebase the PR, squash the commits and sign CLA?

@SaswatB SaswatB force-pushed the master branch 2 times, most recently from d3dff03 to a042a6c Compare January 30, 2019 01:17
@feiskyer
Copy link
Member

/check-cla

@SaswatB
Copy link
Contributor Author

SaswatB commented Jan 30, 2019

/check-cla

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jan 30, 2019
@feiskyer
Copy link
Member

@SaswatB Travis is still failing. Could you fix the validation errors?

@feiskyer
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 31, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, SaswatB

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 31, 2019
@k8s-ci-robot k8s-ci-robot merged commit 99551e7 into kubernetes-sigs:master Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants