Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use jsonpb instead of json for protobuf object output #190

Merged
merged 1 commit into from
Nov 13, 2017

Conversation

miaoyq
Copy link
Contributor

@miaoyq miaoyq commented Nov 8, 2017

Addressed the commend of #178

/assign @Random-Liu

Signed-off-by: Yanqiang Miao miao.yanqiang@zte.com.cn

Signed-off-by: Yanqiang Miao <miao.yanqiang@zte.com.cn>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 8, 2017
@Random-Liu
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 13, 2017
@Random-Liu Random-Liu merged commit 05ad343 into kubernetes-sigs:master Nov 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants