Add --profile-{cpu,mem} flags
#1683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/feature
k8s-ci-robot
added
approved
saschagrunert
force-pushed
the
cpu-mem-profile
branch
4 times, most recently
from
6e76f2f to
4e541d9
Compare
cmd/crictl/main.go
Outdated
| if cpuProfilePath != "" { | ||
| logrus.Infof("Creating CPU profile in: %s", cpuProfilePath) | ||
|
|
||
| file, err := os.Create(cpuProfilePath) |
There was a problem hiding this comment.
so it will fail if file already exists? Should we simply override it instead of failing? It is kind of unusual for a command to fail if retried.
There was a problem hiding this comment.
No, it will re-use the file:
func Create(name string) (*File, error) {
return OpenFile(name, O_RDWR|O_CREATE|O_TRUNC, 0666)
}
653a1da to
a4925a3
Compare
The flags allow debugging `crictl` with respect to CPU and memory consumption. Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert
force-pushed
the
cpu-mem-profile
branch
from
a4925a3 to
67d7a65
Compare
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert, SergeyKanzhelev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
The flags allow debugging
crictlwith respect to CPU and memory consumption.Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Users reported strange memory behavior when running
crictl pswhich is not reproducible for me. Adding the flags will give us more insights and could be beneficial to others.Does this PR introduce a user-facing change?