crictl exec: add --quiet/-q, --ignore-error/-e and --parallel flags
#1622
Conversation
k8s-ci-robot
added
kind/feature
k8s-ci-robot
added
approved
saschagrunert
force-pushed
the
exec
branch
2 times, most recently
from
6f4cc16 to
df1537a
Compare
cmd/crictl/exec.go
Outdated
| if !quiet { | ||
| logrus.Warnf("Ignoring errors: %v", errs) | ||
| } |
There was a problem hiding this comment.
This can be moved to a debug log, if anything.
Why? The users should be told once, before the loop runs, that errors will be ignored. If someone had run this against 100 or so containers and the command failed (not in the PATH or such), then getting the warning that the errors were ignored 100 times is perhaps not so useful.
A small UI/UX change. Not quite the Unix philosophy, though.
There was a problem hiding this comment.
Sounds good, changed to become a debug message.
There was a problem hiding this comment.
What I meant would be something akin to this:
$ crictl exec -p -x --label='test=123' date
WARN[0000] The `--ignore-errors` option has been set. Errors following command execution will be ignored...
...
...
...Perhaps something with better wording.
There was a problem hiding this comment.
Got it, added that additional log line.
saschagrunert
force-pushed
the
exec
branch
2 times, most recently
from
80f3699 to
4756025
Compare
…lags The flags can be used to further manipulate on the exec behavior. Follow-up on: kubernetes-sigs#1603 (comment) Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
|
/approve |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kwilczynski, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
The flags can be used to further manipulate on the exec behavior. Follow-up on: #1603 (comment)
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?