Skip to content

Commit

Permalink
pkg: validate: validate Username not empty in ImageStatus
Browse files Browse the repository at this point in the history
Kubernetes rely on that Username field to provide RunAsUser, we need to
validate runtimes correctly return it. We had recently an issue in
CRI-O for that.

Signed-off-by: Antonio Murdaca <runcom@redhat.com>
  • Loading branch information
runcom committed Feb 17, 2018
1 parent 0ca979b commit 718162d
Show file tree
Hide file tree
Showing 2 changed files with 28 additions and 0 deletions.
16 changes: 16 additions & 0 deletions images/image-user/Dockerfile
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
# Copyright 2018 The Kubernetes Authors.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

FROM busybox
USER 1002
12 changes: 12 additions & 0 deletions pkg/validate/image.go
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,18 @@ var _ = framework.KubeDescribe("Image Manager", func() {
})
})

It("image status get image fields should not have Uid empty [Conformance]", func() {
// runcom/imageuser has been built with a dockerfile having USER 1002
// we test that that user is returned in image status
framework.PullPublicImage(c, "runcom/imageuser")

defer removeImage(c, "runcom/imageuser")

status := framework.ImageStatus(c, "runcom/imageuser")
Expect(status.GetUid()).NotTo(BeNil(), "Image Uid should not be empty")
Expect(status.GetUid().GetValue()).To(Equal(int64(1002)), "Image Uid should be 1002")
})

It("listImage should get exactly 3 image in the result list [Conformance]", func() {
// different tags refer to different images
testImageList := []string{
Expand Down

0 comments on commit 718162d

Please sign in to comment.