-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Wait for metadata cache to sync #1276
🐛 Wait for metadata cache to sync #1276
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @jackkleeman! |
Hi @jackkleeman. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
787cf84
to
01d02b3
Compare
01d02b3
to
64de3d4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oups. Thanks for the fix!
/retitle 🐛 Wait for metadata cache to sync
/lgtm
/approve
@ncdc you might want to backport this to release-0.6
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, jackkleeman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@jackkleeman the descriptiveness check demands at least two lines in the PR body, could you add a newline there to appease it? |
done |
@alvaroaleman thanks for the heads up. @vincepri we'll want to do this for 0.5 and 0.6, right? |
Yes, @jackkleeman do you have time to open a backport PR for |
Backport of kubernetes-sigs#1276 Signed-off-by: Andy Goldstein <goldsteina@vmware.com>
I chatted with @pydctw and she would like to do the backports |
It seems we are missing a wait for cache sync function for the metadata cache. I think we should do to this cache whatever we do to the unstructured one
Descriptiveness check, begone!