-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Controller: Return error when started more than once #1139
🐛 Controller: Return error when started more than once #1139
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Starting the controller more than once is always wrong. Today, it will result in: * Its active workqueue being re-created, resulting in a data race, breaking the guarantee of "there is at most one worker on a given queue key" and messed-up metrics * Starting double as many workers as configured This PR changes that to instead return an error on all subsequent Start attempts.
10c8a01
to
db22614
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@vincepri: The provided milestone is not valid for this repository. Milestones in this repository: [ Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/milestone v0.7.x |
Starting the controller more than once is always wrong. Today, it will
result in:
breaking the guarantee of "there is at most one worker on a given
queue key" and messed-up metrics
This PR changes that to instead return an error on all subsequent Start
attempts.
/assign @vincepri