ensure that indexer has latest instance of an object #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
wlan0
commented
May 5, 2021
| LeaseDuration: 60 * time.Second, | ||
| RenewDeadline: 30 * time.Second, | ||
| RetryPeriod: 15 * time.Second, | ||
| LeaseDuration: 150 * time.Second, |
There was a problem hiding this comment.
It was being renewed too aggressively.
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: krishchow, wlan0 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
BlaineEXE
pushed a commit
to BlaineEXE/cosi-api
that referenced
this pull request
May 29, 2024
update api version & glog -> klog
shanduur
pushed a commit
to shanduur/container-object-storage-interface-api
that referenced
this pull request
Jun 6, 2024
update api version & glog -> klog
shanduur
pushed a commit
to shanduur/container-object-storage-interface-api
that referenced
this pull request
Jun 6, 2024
add minio.yaml for deploying sample driver
BlaineEXE
pushed a commit
to BlaineEXE/cosi-api
that referenced
this pull request
Jun 14, 2024
add minio.yaml for deploying sample driver
BlaineEXE
pushed a commit
to BlaineEXE/cosi-api
that referenced
this pull request
Jun 14, 2024
Introducing delete_context in DriverDeleBucketRequest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The indexer was only being updated when a previously running operation on the same object succeeded. If the operation failed because of invalid input or other non-operational errors , then indexer would never get updated, and the error would keep happening on an infinite loop.
This PR fixes the issue by ensuring that the indexer is always updated. This will ensure that subsequent updates to "fix" the object are also taken into consideration and we prevent the infinite error loops.