-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update go dependencies #137
Conversation
Welcome @MrFreezeex! |
I actually did this because on our cluster with kubernetes 1.25 and min tls version 1.3 (with k8s.gcr.io/cpa/cluster-proportional-autoscaler-amd64:1.8.5) we encountered the following error: Also checked the make test and it also does work fine as well. EDIT: I realized afterwards looking at the commit log that actually 1.8.6 did also a pretty significant bump in dependencies that should fix my specific issues, but well this is probably still relevant I believe. |
2c6022c
to
79c50f7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MrFreezeex Thanks for the PR, I'm inclined to merge this PR and revert mine on #136 as yours updated the go dependencies as well.
Would you mind updating the go version in go.mod file as well as pining the golangci-lint version to v1.51.2 in the build/lint.sh file (to workaround a known bug with golang1.20 and golangci-lint: golangci/golangci-lint#3565)? Thanks.
a04b11a
to
8605e94
Compare
Hey @MrHohn, thanks for the feedback, I cherry-picked your commit in this PR and dropped mine. Feel free to either merge your PR or drop your PR and merge this one that include your commit :D. |
I don't think we need to pin it in lint.sh. Compare to netd impl where there's a lint Github action. |
Yeah sure done 👍, it's the latest version anyway so it should not change much as of right now anyway. |
Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@proton.ch>
Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@proton.ch>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MrFreezeex, MrHohn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR updates go dependencies and go version.