Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go dependencies #137

Merged
merged 3 commits into from
Mar 28, 2023
Merged

Conversation

MrFreezeex
Copy link
Member

@MrFreezeex MrFreezeex commented Feb 28, 2023

This PR updates go dependencies and go version.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 28, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @MrFreezeex!

It looks like this is your first PR to kubernetes-sigs/cluster-proportional-autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-proportional-autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 28, 2023
@MrFreezeex
Copy link
Member Author

MrFreezeex commented Feb 28, 2023

I actually did this because on our cluster with kubernetes 1.25 and min tls version 1.3 (with k8s.gcr.io/cpa/cluster-proportional-autoscaler-amd64:1.8.5) we encountered the following error: github.com/kubernetes-incubator/cluster-proportional-autoscaler/pkg/autoscaler/k8sclient/k8sclient.go:96: Failed to list *v1.Node: Get https://10.233.0.1:443/api/v1/nodes: remote error: tls: protocol version not supported, tested this new version in the cluster with the updated dependencies it and worked fine on my cluster.

Also checked the make test and it also does work fine as well.

EDIT: I realized afterwards looking at the commit log that actually 1.8.6 did also a pretty significant bump in dependencies that should fix my specific issues, but well this is probably still relevant I believe.

Copy link
Member

@MrHohn MrHohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MrFreezeex Thanks for the PR, I'm inclined to merge this PR and revert mine on #136 as yours updated the go dependencies as well.

Would you mind updating the go version in go.mod file as well as pining the golangci-lint version to v1.51.2 in the build/lint.sh file (to workaround a known bug with golang1.20 and golangci-lint: golangci/golangci-lint#3565)? Thanks.

@MrFreezeex MrFreezeex force-pushed the update-dep branch 2 times, most recently from a04b11a to 8605e94 Compare March 3, 2023 08:58
@MrFreezeex
Copy link
Member Author

MrFreezeex commented Mar 3, 2023

@MrFreezeex Thanks for the PR, I'm inclined to merge this PR and revert mine on #136 as yours updated the go dependencies as well.

Would you mind updating the go version in go.mod file as well as pining the golangci-lint version to v1.51.2 in the build/lint.sh file (to workaround a known bug with golang1.20 and golangci-lint: golangci/golangci-lint#3565)? Thanks.

Hey @MrHohn, thanks for the feedback, I cherry-picked your commit in this PR and dropped mine. Feel free to either merge your PR or drop your PR and merge this one that include your commit :D.

@jingyuanliang
Copy link
Contributor

I don't think we need to pin it in lint.sh. Compare to netd impl where there's a lint Github action.

@MrFreezeex
Copy link
Member Author

I don't think we need to pin it in lint.sh. Compare to netd impl where there's a lint Github action.

Yeah sure done 👍, it's the latest version anyway so it should not change much as of right now anyway.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 27, 2023
MrHohn and others added 3 commits March 28, 2023 10:17
Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@proton.ch>
Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@proton.ch>
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 28, 2023
Copy link
Member

@MrHohn MrHohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 28, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MrFreezeex, MrHohn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 28, 2023
@k8s-ci-robot k8s-ci-robot merged commit a24cff6 into kubernetes-sigs:master Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants