Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 test/framework add WatchDaemonSetLogsByLabelSelector method #9984

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

chrischdi
Copy link
Member

@chrischdi chrischdi commented Jan 11, 2024

What this PR does / why we need it:

Implements WatchDaemonSetLogsByLabelSelector function.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #9983

/area test-framework

@k8s-ci-robot
Copy link
Contributor

@chrischdi: The label(s) area/test-framework cannot be applied, because the repository doesn't have them.

In response to this:

What this PR does / why we need it:

Implements WatchDaemonSetLogsByLabelSelector function.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #9983

Area example:
/area test-framework

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label labels Jan 11, 2024
@chrischdi chrischdi changed the title test/framework add WatchDaemonSetLogsByLabelSelector method 🌱 test/framework add WatchDaemonSetLogsByLabelSelector method Jan 11, 2024
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 11, 2024
@chrischdi
Copy link
Member Author

/area e2e-testing

@k8s-ci-robot k8s-ci-robot added area/e2e-testing Issues or PRs related to e2e testing and removed do-not-merge/needs-area PR is missing an area label labels Jan 11, 2024
test/framework/daemonset_helpers.go Outdated Show resolved Hide resolved
test/framework/daemonset_helpers.go Outdated Show resolved Hide resolved
@chrischdi chrischdi force-pushed the pr-test-ds-watchlogs branch from 2745714 to 46bd506 Compare January 11, 2024 13:48
@chrischdi chrischdi force-pushed the pr-test-ds-watchlogs branch from 46bd506 to 6083474 Compare January 11, 2024 14:35
@sbueringer
Copy link
Member

Thx!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 12, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3598886cd76cd20cc021bb01f4357a887698f0ee

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 12, 2024
@chrischdi
Copy link
Member Author

/cherry-pick release-1.6

@k8s-infra-cherrypick-robot

@chrischdi: once the present PR merges, I will cherry-pick it on top of release-1.6 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot merged commit 005971d into kubernetes-sigs:main Jan 12, 2024
20 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.7 milestone Jan 12, 2024
@k8s-infra-cherrypick-robot

@chrischdi: new pull request created: #9994

In response to this:

/cherry-pick release-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/e2e-testing Issues or PRs related to e2e testing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test framework does not help investigating daemonset pods
4 participants