Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 add docs/examples for pre-release and nightly img version deployments with clusterctl #9797

Merged
merged 1 commit into from
Jan 15, 2024
Merged

📖 add docs/examples for pre-release and nightly img version deployments with clusterctl #9797

merged 1 commit into from
Jan 15, 2024

Conversation

cahillsf
Copy link
Member

@cahillsf cahillsf commented Dec 3, 2023

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #9604

/area release

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/release Issues or PRs related to releasing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 3, 2023
@cahillsf cahillsf mentioned this pull request Dec 3, 2023
Closed
@cahillsf cahillsf force-pushed the document-rc-beta-release-consumption branch from a7135e1 to 92017d6 Compare December 5, 2023 00:08
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 5, 2023
@cahillsf cahillsf marked this pull request as ready for review December 5, 2023 00:11
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 5, 2023
@k8s-ci-robot k8s-ci-robot requested a review from ykakarap December 5, 2023 00:11
@cahillsf cahillsf changed the title 📖 add section for core CAPI pre-release consumption 📖 add docs/examples for pre-release and nightly img version deployments with clusterctl Dec 5, 2023
@chrischdi
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 5, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7735f31aa1ef11f138cd034298f161f2e68af273

sbueringer
sbueringer reviewed Dec 15, 2023
View reviewed changes
docs/book/src/clusterctl/commands/upgrade.md

<aside class="note warning">

<h1> Deploying nightly release images </h1>
Copy link
Member

@sbueringer sbueringer Dec 15, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for writing this up!

Can you please try if it's possible to overwrite only the URL for the providers instead of the images (see: #9604 (comment))

This way we would also get the latest manifests if I understand it correctly

(also gave a pointer on how to use core CAPI nightly images for provider e2e tests there)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 @sbueringer have not gotten any traction on the linked issue re adding googlestorage repo support

wdyt if i update this current PR to remove the example for overwriting the image tag and simplify the doc update to mention the location of the nightly release YAMLs.

i will also create a follow up issue to address Add support for consuming nightly release manifests in clusterctl?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pushed up some changes here when you have a chance to take another pass

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx!

@cahillsf cahillsf force-pushed the document-rc-beta-release-consumption branch from 92017d6 to af2a49b Compare January 14, 2024 21:21
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 14, 2024
@cahillsf cahillsf mentioned this pull request Jan 14, 2024
Closed
@sbueringer
Copy link
Member

Thank you!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 15, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0e3392a14d834537a73217436416c9d67f17f71f

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 15, 2024
@k8s-ci-robot k8s-ci-robot merged commit 0852ab4 into kubernetes-sigs:main Jan 15, 2024
19 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.7 milestone Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbueringer sbueringer sbueringer left review comments

@chrischdi chrischdi Awaiting requested review from chrischdi

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@ykakarap ykakarap Awaiting requested review from ykakarap

Assignees

@chrischdi chrischdi

@sbueringer sbueringer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release Issues or PRs related to releasing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
4 participants
@cahillsf @k8s-ci-robot @chrischdi @sbueringer