-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.4] 🌱 Bump Go version to v1.20.11 #9687
[release-1.4] 🌱 Bump Go version to v1.20.11 #9687
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/hold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm cancel
One finding - think I missed this myself in more than one previous cherry-pick
@@ -165,7 +165,7 @@ def load_provider_tiltfiles(): | |||
|
|||
tilt_helper_dockerfile_header = """ | |||
# Tilt image | |||
FROM golang:1.20.10 as tilt-helper | |||
FROM golang:1.20.11 as tilt-helper |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we update the version on L178 as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch @killianmuldoon , my fault assuming we have 1.20.10 everywhere when searching for it in IDE 🤦🏼♂️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah - I think I did the exact same for the last bump or even more 😅
Signed-off-by: Furkat Gofurov <furkat.gofurov@suse.com>
edbaa05
to
984ac95
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
LGTM label has been added. Git tree hash: 39d869d6abe83735769ae2cb1f6ff88170063c09
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: killianmuldoon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
What this PR does / why we need it:
Manual cherry-pick of #9683
Bump the go version used to build CAPI to v1.20.11
xref: https://go.dev/doc/devel/release#go1.20.11
/area dependency