Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 Update MachinePool Machines proposal with diagrams #9664

Merged
merged 1 commit into from
Dec 13, 2023
Merged

📖 Update MachinePool Machines proposal with diagrams #9664

merged 1 commit into from
Dec 13, 2023

Conversation

Jont828
Copy link
Contributor

@Jont828 Jont828 commented Nov 3, 2023

What this PR does / why we need it: Updates the MachinePool Machines proposal to reflect the work in #8828, #8842, #9619, and

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

/area machinepool

@k8s-ci-robot k8s-ci-robot added area/machinepool Issues or PRs related to machinepools cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 3, 2023
@Jont828
Copy link
Contributor Author

Jont828 commented Nov 3, 2023

/assign @shyamradhakrishnan @CecileRobertMichon @mboersma @fabriziopandini

@Jont828 Jont828 force-pushed the mpm-proposal-update branch from f071814 to 4c484ee Compare November 3, 2023 01:38
CecileRobertMichon
CecileRobertMichon reviewed Nov 3, 2023
View reviewed changes
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating the proposal @Jont828. Most of my comments are around the diagrams, I'm having a hard time following what each box is referring to even though I;m familiar with the code implementation so I could see this being even more confusing to a newcomer. Consider adding actors so it's clear who is doing what as @shyamradhakrishnan suggested, and keeping the text boxes action-oriented

docs/proposals/20220209-machinepool-machines.md Outdated Show resolved Hide resolved
docs/proposals/images/machinepool-machines/inframachinepool-create-replicas.plantuml Outdated Show resolved Hide resolved
docs/proposals/images/machinepool-machines/inframachinepool-create-replicas.plantuml Outdated Show resolved Hide resolved
docs/proposals/images/machinepool-machines/inframachinepool-create-replicas.plantuml Outdated Show resolved Hide resolved
docs/proposals/images/machinepool-machines/inframachinepool-create-replicas.plantuml Outdated Show resolved Hide resolved
docs/proposals/images/machinepool-machines/inframachinepool-delete-replicas.plantuml Outdated Show resolved Hide resolved
docs/proposals/images/machinepool-machines/inframachinepool-delete-replicas.plantuml Outdated Show resolved Hide resolved
docs/proposals/images/machinepool-machines/inframachinepool-delete-replicas.plantuml Outdated Show resolved Hide resolved
docs/proposals/images/machinepool-machines/machinepool-machines-reconcile.plantuml Outdated Show resolved Hide resolved
docs/proposals/images/machinepool-machines/machinepool-machines-reconcile.plantuml Outdated Show resolved Hide resolved
@Jont828 Jont828 force-pushed the mpm-proposal-update branch from b604148 to fc06ff8 Compare November 30, 2023 18:46
CecileRobertMichon
CecileRobertMichon reviewed Dec 11, 2023
View reviewed changes
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Please squash commits

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 11, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: dc3083d567901919b93ec3b8bbd518fc9a2cead3

@Jont828 Jont828 force-pushed the mpm-proposal-update branch from 756ae30 to 711ed35 Compare December 11, 2023 23:47
@Jont828
Copy link
Contributor Author

Jont828 commented Dec 11, 2023

@CecileRobertMichon Done!

@CecileRobertMichon
Copy link
Contributor

there are broken link errors, PTAL

[✖] images/machinepool-machines/inframachinepool-scale-up.png → Status: 400
[✖] images/machinepool-machines/inframachinepool-scale-down.png → Status: 400

@Jont828 Jont828 force-pushed the mpm-proposal-update branch from 711ed35 to de70714 Compare December 12, 2023 01:09
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 12, 2023
CecileRobertMichon
CecileRobertMichon reviewed Dec 13, 2023
View reviewed changes
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 13, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 49904257b63b9259a6e9250f7337da965d1a9874

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 13, 2023
@k8s-ci-robot k8s-ci-robot merged commit 2df4891 into kubernetes-sigs:main Dec 13, 2023
18 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.7 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CecileRobertMichon CecileRobertMichon CecileRobertMichon left review comments

@elmiko elmiko Awaiting requested review from elmiko

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@fabriziopandini fabriziopandini Awaiting requested review from fabriziopandini

@mboersma mboersma Awaiting requested review from mboersma

@shyamradhakrishnan shyamradhakrishnan Awaiting requested review from shyamradhakrishnan

Assignees

@mboersma mboersma

@fabriziopandini fabriziopandini

@CecileRobertMichon CecileRobertMichon

@shyamradhakrishnan shyamradhakrishnan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/machinepool Issues or PRs related to machinepools cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.
6 participants
@Jont828 @k8s-ci-robot @CecileRobertMichon @shyamradhakrishnan @mboersma @fabriziopandini