Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.5] 🐛 Fix broken e2e test clusterclass #9504

Merged
merged 1 commit into from
Sep 27, 2023
Merged

[release-1.5] 🐛 Fix broken e2e test clusterclass #9504

merged 1 commit into from
Sep 27, 2023

Conversation

killianmuldoon
Copy link
Contributor

Issue with required not being defined was introduced in #9501. I'm not sure of the root cause, but required only seems to be required on older versions of Kubernetes.

The test was passing e2e-min-k8s-main - which runs with Kubernetes v1.25 - but failing e2e-min-k8s-release-1-5 - which runs Kubernetes v1.24.

Either way we should make this change in both branches after we see if it fixes the underlying issue here.

@killianmuldoon
Fix broken e2e test clusterclass
f8eab07 
Signed-off-by: killianmuldoon <kmuldoon@vmware.com>
@k8s-ci-robot k8s-ci-robot added this to the v1.5 milestone Sep 27, 2023
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 27, 2023
@k8s-ci-robot k8s-ci-robot added do-not-merge/needs-area PR is missing an area label size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 27, 2023
@killianmuldoon killianmuldoon changed the title 🐛 Fix broken e2e test clusterclass [release-1.5] 🐛 Fix broken e2e test clusterclass Sep 27, 2023
killianmuldoon
killianmuldoon commented Sep 27, 2023
View reviewed changes
Copy link
Contributor Author

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/area e2e-testing

/test

@k8s-ci-robot k8s-ci-robot added the area/e2e-testing Issues or PRs related to e2e testing label Sep 27, 2023
@k8s-ci-robot
Copy link
Contributor

@killianmuldoon: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

  • /test pull-cluster-api-build-release-1-5
  • /test pull-cluster-api-e2e-full-dualstack-and-ipv6-release-1-5
  • /test pull-cluster-api-e2e-full-release-1-5
  • /test pull-cluster-api-e2e-mink8s-release-1-5
  • /test pull-cluster-api-e2e-release-1-5
  • /test pull-cluster-api-e2e-workload-upgrade-1-27-1-28-release-1-5
  • /test pull-cluster-api-test-mink8s-release-1-5
  • /test pull-cluster-api-test-release-1-5
  • /test pull-cluster-api-verify-release-1-5

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-apidiff-release-1-5
  • /test pull-cluster-api-e2e-informing-release-1-5
  • /test pull-cluster-api-e2e-scale-release-1-5-experimental

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-apidiff-release-1-5
  • pull-cluster-api-build-release-1-5
  • pull-cluster-api-e2e-informing-release-1-5
  • pull-cluster-api-e2e-release-1-5
  • pull-cluster-api-test-release-1-5
  • pull-cluster-api-verify-release-1-5

In response to this:

/area e2e-testing

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-area PR is missing an area label label Sep 27, 2023
@killianmuldoon
Copy link
Contributor Author

/test pull-cluster-api-e2e-mink8s-release-1-5

chrischdi
chrischdi reviewed Sep 27, 2023
View reviewed changes
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 27, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7a9e4fa06d14767458d9ec55363cb2c51d988963

@killianmuldoon
Copy link
Contributor Author

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: killianmuldoon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 27, 2023
@k8s-ci-robot k8s-ci-robot merged commit 83e9c53 into kubernetes-sigs:release-1.5 Sep 27, 2023
13 checks passed
@killianmuldoon killianmuldoon mentioned this pull request Sep 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrischdi chrischdi chrischdi left review comments

@richardcase richardcase Awaiting requested review from richardcase

Assignees

@chrischdi chrischdi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/e2e-testing Issues or PRs related to e2e testing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.
3 participants
@killianmuldoon @k8s-ci-robot @chrischdi