-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Drop MachinePools from Dualstack tests #9477
🐛 Drop MachinePools from Dualstack tests #9477
Conversation
Signed-off-by: killianmuldoon <kmuldoon@vmware.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/area e2e-testing
/test pull-cluster-api-e2e-full-dualstack-and-ipv6-main
Thank you! /lgtm (tide will wait for e2e-full-dualstack for merge anyway) |
LGTM label has been added. Git tree hash: 05b8a6f31037fe537ac4e205c5c877ff8dcada34
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@killianmuldoon Can you add info to the new umbrella issue for MachinePools in ClusterClass? I'm looking to re-implement this soon. #10028 |
I think the only information I have is that MachinePools should be added back into the dualstack tests - no other specific implementation details that I'm aware of. |
Fixes a failure in the dualstack e2e tests caused by the introduction of MachinePools in #9393
This PR drops the MachinePools in the templates. I'll add info on the umbrella issue for how to make the dualstack e2e tests work with MachinePools.
Related to #5991