Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Drop MachinePools from Dualstack tests #9477

Conversation

killianmuldoon
Copy link
Contributor

Fixes a failure in the dualstack e2e tests caused by the introduction of MachinePools in #9393

This PR drops the MachinePools in the templates. I'll add info on the umbrella issue for how to make the dualstack e2e tests work with MachinePools.

Related to #5991

Signed-off-by: killianmuldoon <kmuldoon@vmware.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 21, 2023
Copy link
Contributor Author

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/area e2e-testing
/test pull-cluster-api-e2e-full-dualstack-and-ipv6-main

@k8s-ci-robot k8s-ci-robot added area/e2e-testing Issues or PRs related to e2e testing and removed do-not-merge/needs-area PR is missing an area label labels Sep 21, 2023
@sbueringer
Copy link
Member

sbueringer commented Sep 21, 2023

Thank you!

/lgtm
/approve

(tide will wait for e2e-full-dualstack for merge anyway)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 21, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 05b8a6f31037fe537ac4e205c5c877ff8dcada34

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 21, 2023
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 338fe5b into kubernetes-sigs:main Sep 21, 2023
15 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.6 milestone Sep 21, 2023
@willie-yao
Copy link
Contributor

I'll add info on the umbrella issue for how to make the dualstack e2e tests work with MachinePools.

@killianmuldoon Can you add info to the new umbrella issue for MachinePools in ClusterClass? I'm looking to re-implement this soon. #10028

@killianmuldoon
Copy link
Contributor Author

I think the only information I have is that MachinePools should be added back into the dualstack tests - no other specific implementation details that I'm aware of.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/e2e-testing Issues or PRs related to e2e testing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants