🌱 Enforce import restrictions in all API packages

[Ankitasw]

What this PR does / why we need it:
This PR enforces import restrictions on API packages to prevent regression mentioned in #9011.

Which issue(s) this PR fixes (optional, in fixes #(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

[Ankitasw]

/area api

[sbueringer]

Thx!

/hold
for merging the other PRs first

[sbueringer]

/hold cancel

All other PRs should be merged now

[chrischdi]

changes seem reasonable 👍

nice work

[chrischdi]

Wondering if we can say to run it just anywhere and respect the config files? Or determine the paths to test by find -name ".import-restrictions"

[sbueringer]

Let's maybe try to optimize this in a follow up

[Ankitasw]

Wondering if we can say to run it just anywhere and respect the config files?

I have not tested it by removing the sub package, I can see how it behaves.

Or determine the paths to test by find -name ".import-restrictions"

Otherwise it is ok to do this as well.

[sbueringer]

I'm fine with optimizing if we find a safe way to do it and if we think it's worth the effort. I would just like to have the restrictions in place :) (so I don't want to wait on finalizing the scripting :))

[Ankitasw]

Yeah a follow up PR sounds good. I don't have much idea about this myself 😅

[sbueringer]

I would say it's fine as is. @chrischdi feel free to open a follow-up PR if you want to improve it :)

[sbueringer]

@Ankitasw I realized that this might be a bit confusing :). So here is the summary what restrictions we should have:

• ./api: block all except conversion
• ./api/v1beta1: block all
• ./bootstrap/kubeadm/api: block all except conversion
• ./bootstrap/kubeadm/api/v1beta1: block all
• ./cmd/clusterctl/api: block all
• ./controlplane/kubeadm/api: block all except conversion
• ./controlplane/kubeadm/api/v1beta1: block all
• ./exp/addons/api: block all except conversion
• ./exp/addons/api/v1beta1: block all
• ./exp/api: block all except conversion
• ./exp/api/v1beta1: block all
• ./exp/ipam/api: block all except conversion
• ./exp/ipam/api/v1alpha1: block all
• ./exp/runtime/api: block all except conversion
• ./exp/runtime/api/v1alpha1: block all
• ./test/infrastructure/docker/api: block all except conversion
• ./test/infrastructure/docker/api/v1beta1: block all
• ./test/infrastructure/docker/exp/api: block all except conversion
• ./test/infrastructure/docker/exp/api/v1beta1: block all
• ./test/infrastructure/inmemory/api: block all except conversion
• ./test/infrastructure/inmemory/api/v1alpha1: block all

[sbueringer]

import-restrictions look good. Last one: #9461 (comment)

Would be great if you can clean these up as well :)

[k8s-ci-robot]

@Ankitasw: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-cluster-api-apidiff-main	615b5e6	link	false	/test pull-cluster-api-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[sbueringer]

Thank you very much!!

/lgtm
/approve

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 7d31de2d46af047f2c8b6f106fe71f0df509957c

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sbueringer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment