Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Move docker infrastructure experimental API v1beta1 webhooks to separate package #9460

Merged

Conversation

Ankitasw
Copy link
Member

What this PR does / why we need it:

To work towards #9011, we need to remove the reliance on controller-runtime from the API packages.

Which issue(s) this PR fixes (optional, in fixes #(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

/area api

@k8s-ci-robot k8s-ci-robot added area/api Issues or PRs related to the APIs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 19, 2023
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 19, 2023
@Ankitasw Ankitasw force-pushed the move-docker-exp-api-webhooks branch 2 times, most recently from 85c2d25 to 9d5404e Compare September 19, 2023 11:44
@sbueringer
Copy link
Member

Thx!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 19, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 602951e5816897697df5d0bc35c70b2d322cb4f5

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 19, 2023
@k8s-ci-robot k8s-ci-robot merged commit 66d18d9 into kubernetes-sigs:main Sep 19, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.6 milestone Sep 19, 2023
@Ankitasw Ankitasw deleted the move-docker-exp-api-webhooks branch September 19, 2023 14:34
@furkatgofurov7
Copy link
Member

/retitle 🌱 Move docker infrastructure experimental API v1beta1 webhooks to separate package

@k8s-ci-robot k8s-ci-robot changed the title 🌱 Move docker infrastructure experimental API v1beta1 webhooks to sepa… 🌱 Move docker infrastructure experimental API v1beta1 webhooks to separate package Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api Issues or PRs related to the APIs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants