-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 observability: move metrics to config and use sidecar in kube-state-metrics #9390
Conversation
@chrischdi: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
aa51a85
to
d709526
Compare
/area devtools |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one, just a few smaller findings
d709526
to
4b4df56
Compare
Thank you! /lgtm |
LGTM label has been added. Git tree hash: 58ea5fcdb7a72dee5dea369e481b5f73c35fe33d
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This PR:
hack/observability/kube-state-metrics
toconfig/metrics
.config/metrics/crd-clusterrole.yaml
for the aggregated clusterrole for kube-state-metricskustomization.yaml
toconfig/metrics
which includes the above twoobservability
which have the labelkube-state-metrics/custom-resource
settilt up
:deploy_kustomizations
which allows to define paths to additional kustomizations which then get deployed to the clusterWhich issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
/area observability